Re: ALSA official git repository

From: Linus Torvalds
Date: Fri May 27 2005 - 12:28:33 EST




On Fri, 27 May 2005, Sean wrote:
> >
> > Now, arguably gitweb should ignore whitespace at the beginning, but
> > equally arguably your commits shouldn't have them either...
>
> Perhaps git should enforce this? Patch attached.
>
> Remove leading empty lines from commit messages.
>
> Signed-off-by: Sean Estabrooks <seanlkml@xxxxxxxxxxxx>

I'm not sure.

The thing is, right now git allows binary commit messages if somebody
really wants to. Now, a lot of the _tools_ end up only printing up to the
first '\0' or something, but in general, maybe somebody actually wants to
embed his own strange stuff in there (eg use encryption but still use
standard git tools).

Which makes me worry. So I _do_ do whitespace cleanup in my "apply email
patches" scripts, but I'm not sure whether the core should care about the
data that people feed it, even for commit messages.

Opinions?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/