Trivial module unload problem in 2.6.12-rc5[-mm1]

[Keith Moore]

I've found a trivial module unload problem in the 2.6.12-rc5 and (-mm1)
kernels.

net/ipv4/multipath_drr.c can cause an oops soon after unloading. Its
module init routine calls multipath_alg_register() with the incorrect
IP_MP_ALG_RR value, but its module exit routine calls
multipath_alg_deregister() with the *correct* IP_MP_ALG_DRR value.

Easy fix:

--- linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c.old	2005-05-28
15:03:24.000000000 +0200
+++ linux-2.6.12-rc5-mm1/net/ipv4/multipath_drr.c	2005-05-28
15:03:31.000000000 +0200
@@ -244,7 +244,7 @@ static int __init drr_init(void)
 	if (err)
 		return err;

-	err = multipath_alg_register(&drr_ops, IP_MP_ALG_RR);
+	err = multipath_alg_register(&drr_ops, IP_MP_ALG_DRR);
 	if (err)
 		goto fail;


Thanks,
KM

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/