Re: 2.6.12-rc5-git3 fails compile -- acpi_boot_table_init

From: Linus Torvalds
Date: Sun May 29 2005 - 13:58:41 EST




On Sat, 28 May 2005, Alexander Nyberg wrote:
>
> This is a neverending story
>
> linux/acpi.h contains empty declarations for acpi_boot_init() &
> acpi_boot_table_init() but they are nested inside #ifdef CONFIG_ACPI.
>
> So we'll have to #ifdef in arch/i386/kernel/setup.c: setup_arch()

Wouldn't it be much nicer to just fix <linux/acpi.h> instead? Or, if you
really prefer this, then you should remove the now useless code from
acpi.h. In either case, this patch looks wrong.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/