Re: [patch 6/9] dlm: clear recovery flags

[David Teigland]

On Thu, Jun 02, 2005 at 10:19:20AM +0200, Arjan van de Ven wrote:
> On Thu, 2005-06-02 at 16:03 +0800, David Teigland wrote:
> > +	clear_bit(LSFL_LOCKS_VALID, &ls->ls_flags);
> > +	clear_bit(LSFL_ALL_LOCKS_VALID, &ls->ls_flags);
> >  	clear_bit(LSFL_DIR_VALID, &ls->ls_flags);
> >  	clear_bit(LSFL_ALL_DIR_VALID, &ls->ls_flags);
> >  	clear_bit(LSFL_NODES_VALID, &ls->ls_flags);
> 
> btw do these need to be atomic? right now these are atomic ops and thus
> very expensive... you might want to switch to nonatomic variants if
> that's not needed.

No they don't, I didn't know about the __ non-atomics.  I'll go through
and switch, thanks.

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/