Re: [patch] spinlock consolidation, v2

[Christoph Hellwig]

On Fri, Jun 03, 2005 at 05:40:29PM +0200, Ingo Molnar wrote:
> 
> the latest version of the spinlock consolidation patch can be found at:
> 
>   http://redhat.com/~mingo/spinlock-patches/consolidate-spinlocks.patch
> 
> the patch is now complete in the sense that it does everything i wanted 
> it to do. If you have any other suggestions (or i have missed to 
> incorporate an earlier suggestion of yours), please yell.

Looks pretty nice, but your usage of asm-generic is totally wrong.
files in asm-generic must only ever be used for default implementations
of asm/ headers, and _never_ be included from common code.  But your
asm-generic files are only ever used from linux/spinlock.h, so there's
no point at all in splitting them out in the first time.
Similarly there's no point in a separate linux/spinlock_smp.h and
linux/spinlock_up.h - it'll only cause some driver writers to include
either of them directly and break the build for either UP or SMP.
If you absolutely want to split them add an #error if not included from
spinlock.h

Little nitpick no 2: please include linux/*.h always before asm/*.h
(in linux/jbd.h)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/