Re: [PATCH] Support for read-only MMC cards

From: Pierre Ossman
Date: Sat Jun 04 2005 - 15:06:48 EST


Russell King wrote:

>
>I'd prefer this to be:
>
> printk(KERN_INFO "%s: %s %s %dKiB%s\n",
> md->disk->disk_name, mmc_card_id(card), mmc_card_name(card),
> (card->csd.capacity << card->csd.read_blkbits) / 1024,
> card->csd.cmdclass & CCC_BLOCK_WRITE ? "" : " (ro)");
>
>
>

I'd rather not since the SD patches have a similar test but on a
different condition. It makes the [SD] patch a bit easier to follow when
trying to determine what it does. Since it doesn't seem to be getting
included anytime soon I'm trying to do what I can to keep it maintainable.

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/