Re: pci_enable_msi() for everyone?

From: Greg KH
Date: Tue Jun 07 2005 - 00:21:57 EST


On Mon, Jun 06, 2005 at 05:23:17PM -0700, Roland Dreier wrote:
> Greg> Motherboard quirks are one thing. Broken devices are a
> Greg> totally different thing. If there are too many of them,
> Greg> then the current situation is acceptable to me. Does ib
> Greg> have devices that will break with MSI?
>
> Yes, I believe some versions of the firmware for Mellanox HCAs have
> problems with MSI.

Ick ick ick, and people think writing drivers is "easy"...

> Greg> In looking at that, I don't see a way to get rid of the msix
> Greg> stuff. So that's probably just going to stay the same.
>
> OK -- we'll just have to make sure that the switch from MSI mode to
> MSI-X mode is implementated correctly.

Hm good point, I think I got that wrong in my patch, let me go fix that
up...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/