Re: [PATCH 7/7] v9fs: debug and support routines (2.0)

[Jan-Benedict Glaw]

On Tue, 2005-06-07 09:49:51 -0500, ericvh@xxxxxxxxx <ericvh@xxxxxxxxx> wrote:
> +++ b/fs/9p/error.h

If you really need to use this struct, ...

> +/* FixMe - reduce to a reasonable size */
> +static struct errormap errmap[] = {
> +	{"Operation not permitted", 1},
> +	{"wstat prohibited", 1},
> +	{"No such file or directory", 2},
> +	{"file not found", 2},
> +	{"Interrupted system call", 4},
> +	{"Input/output error", 5},

...then please use the E macros of errno.h and not these numeric
constants. errno values may vary between ports.

MfG, JBG

-- 
Jan-Benedict Glaw       jbglaw@xxxxxxxxxx    . +49-172-7608481             _ O _
"Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg  _ _ O
 fuer einen Freien Staat voll Freier BÃrger" | im Internet! |   im Irak!   O O O
ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

Attachment: signature.asc
Description: Digital signature