Re: [Penance PATCH] PCI: clean up the MSI code a bit

From: Andi Kleen
Date: Wed Jun 08 2005 - 08:46:08 EST


On Tue, Jun 07, 2005 at 11:35:59PM -0700, Greg KH wrote:
> Ok, I'm very sorry for wasting people's time on this. In the end, I
> agree that the MSI code should stay as is. It's just to complex and
> confusing to enable it always for all devices at this time. I'll put
> the pci_enable/pci_disable idea on my TODO list to try to help out with
> some of the logic that every-other pci driver seems to have to duplicate
> all the time. That seems like the best way forward.


I disagree it should stay as it is. Basically you are trading
a bit less complexity in Infiniband now for a lot of code everywhere.

Does not seem like a good tradeoff.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/