Re: [PATCH] Adds support for TEA5767 chipset on V4L

From: Gerd Knorr
Date: Tue Jun 14 2005 - 02:31:53 EST


Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxx> writes:

> >>+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)
> >>+#include "tuner.h"
> >>+#include "i2c-compat.h"
> >>+#else
> >>+#include <media/tuner.h>
> >>+#endif

> >No such test please, it is useless. This is Linux 2.6.x, no need to
> >check this.

> There's a script to eliminate this before submiting the patch... For
> some reason, as you pointed, it had failed for this code... I'll review
> it next time.

btw: is anyone testing the v4l cvs on 2.4 kernels? I stopped doing
that quite a while ago, alot of stuff (dvb support) doesn't build on
2.4 kernels anyway, so its probably reasonable to cleanup the code in
cvs as well and simply drop the 2.4 code ...

Gerd

--
-mm seems unusually stable at present.
-- akpm about 2.6.12-rc3-mm3
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/