Re: 2.6.12: connection tracking broken?

From: Patrick McHardy
Date: Mon Jun 20 2005 - 20:46:45 EST


Phil Oester wrote:
> The changes were originally made to fix conntrack unload problems with
> raw sockets. My original patch performed the nf_reset in the socket
> code, but Patrick suggested moving it to ip_output. The below patch
> reverts the ip_output changes, and implements the original suggested
> changes to raw socket handling.
>
> While this is unlikely to be the permanent solution, it will fix the
> current bridging problems while retaining the raw socket fixes. I'd
> suggest that this could be included in -stable while researching
> other solutions.

I disagree. We will probably have a final solution within a few days,
so I don't think we need to submit "temporary" fixes yet. Your patch
actually causes a regression for people not using bringe-netfilter,
unplugging a network cable can cause the conntrack module to become
unloadable again.

Regards
Patrick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/