one-liner bug in tcp_input.c

From: Zubin D. Dittia
Date: Tue Jun 21 2005 - 00:58:10 EST


I was browsing the kernel sources and I think there is a bug near the
top of the tcp_init_metrics() function (in net/ipv4/tcp_input.c). The
lines are:

if (dst_metric_locked(dst, RTAX_CWND))
tp->snd_cwnd_clamp = dst_metric(dst, RTAX_CWND);

I think the dst_metric() function should have been called in the first
line above, and not dst_metric_locked() -- this is how it is done in the
code lines following that one.

-Zubin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/