Re: [PATCH 3/4] files: change fd_install assertion

From: Artem B. Bityuckiy
Date: Fri Jun 24 2005 - 07:13:04 EST


Dipankar Sarma wrote:
- if (unlikely(fdt->fd[fd] != NULL))
- BUG();
+ BUG_ON(fdt->fd[fd] != NULL);
rcu_assign_pointer(fdt->fd[fd], file);
spin_unlock(&files->file_lock);
}

Why is this better ?


--
Best regards, Artem B. Bityuckiy
Oktet Labs (St. Petersburg), Software Engineer.
+78124286709 (office) +79112449030 (mobile)
E-mail: dedekind@xxxxxxxxxxxx, web: http://www.oktetlabs.ru
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/