Re: [patch][ia64]Refuse kprobe on ivt code
From: David Mosberger
Date: Fri Jun 24 2005 - 14:14:12 EST
>>>>> On Fri, 24 Jun 2005 11:45:46 -0700, Keshavamurthy Anil S <anil.s.keshavamurthy@xxxxxxxxx> said:
Anil> On Thu, Jun 23, 2005 at 06:38:33PM -0700, David Mosberger wrote:
>> Please do the checking based on the .text.ivt section instead (and add
>> the necessary labels to vmlinux.S and asm-ia64/sections.h).
Anil> Subject: Refuse kprobe insert on IVT code
Anil> Not safe to insert kprobes on IVT code.
Anil> This patch checks to see if the address on which Kprobes is being
Anil> inserted is in ivt code and if it is in ivt code then
Anil> refuse to register kprobe.
Anil> Take 1: This patch is based on review comments from David Mosberger,
Anil> now checking based on .text.ivt
Anil> Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
Looks fine, except:
Anil> +/* Returns non-zero if the addr is in the Interrupt Vector Table */
Anil> +static inline int in_ivt_functions(unsigned long addr)
Anil> +{
Anil> + extern char __start_ivt_text[], __end_ivt_text[];
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Anil> + return (addr >= (unsigned long)__start_ivt_text
Anil> + && addr < (unsigned long)__end_ivt_text);
Anil> +}
Surely you meant to use the declaration from sections.h instead?
Thanks,
--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/