Re: 2.6.12 breaks 8139cp

[Ed Sweetman]

Sorry, i'm retarded, i pasted the wrong changelog line.

<hch@xxxxxx>
	[8139TOO]: Use rtnl_lock_interruptible()
	
	The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
	doing the actual work once it's been kill_proc()ed on module removal
	time.
	
	Based on debugging and an earlier patch that adds a driver-private
	semaphore from Herbert Xu.
	
	Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

This seems to be the only patch that contains a change to the 8139too code between 
working and non-working code.

nothing in mm's patchset seems to have anything to cause these problems.




Ed Sweetman wrote:

> this is in the changefile to 2.6.11.   This seems to be the real 
> culprit.  I guarantee you if this patch is reverted, there will be no 
> problems.
>
> <romieu@xxxxxxxxxxxxx>
>     [PATCH] r8169: hint for Tx flow control
>     
>     return 1 in start_xmit() when the required descriptors are not 
> available
>     and wait for more room.
>     
>     Signed-off-by: Francois Romieu <romieu@xxxxxxxxxxxxx>
>
>
>
>
> Ed Sweetman wrote:
>
> > Pierre Ossman wrote:
> >
> > > Bjorn Helgaas wrote:
> > >
> > >  
> > >
> > > > Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one
> > > > doesn't.  I bet something's broken there.
> > > >
> > > > Can you try the attached debugging patch?  And please collect the
> > > > output of lspci, too.
> > > >
> > > >
> > > >   
> > >
> > >
> > >
> > > I tried the attached patch and it had no effect. I also tried porting
> > > the 2.6.11 way of handling the VIA quirk but it didn't have any effect.
> > > I'll try a more complete port tomorrow (it was a bit of a hack this 
> > > time).
> > >
> > >  
> > 2.6.11-mm4 doesn't work. So i'm guessing 2.6.11 wont work either 
> > which may be why backporting it's via fixes didn't do anything.  I'm 
> > gonna try vanilla and if that by some crazy chance works, then it'll 
> > be fairly easy to see what change did it since mm has a nice Changelog.
> > -
> > To unsubscribe from this list: send the line "unsubscribe 
> > linux-kernel" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/