Re: [PATCH][RFC 2] char: Add Dell Systems Management Base driver

[Brian Gerst]

Alan Cox wrote:
> > +
> > +	/* generate SMI */
> > +	asm("outb %b0,%w1" : :
> > +	      "a" (ci_cmd->command_code),
> > +	      "d" (ci_cmd->command_address),
> > +	      "b" (command_buffer_phys_addr),
> > +	      "c" (ci_cmd->signature));
> > +
>
>
> Is there a reason this bit is asm not an outb() macro. If its needed in
> asm for the SMI behaviour then document that fact so nobody "optimises"
> it.

Because it has to load values into %ebx and %ecx for the SMI call.  The 
macro doesn't allow for that.

--
				Brian Gerst


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/