Re: fix silly config option.

[Michael Krufky]

Dave Jones wrote:

> CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
> author meant to create.
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> --- linux-2.6.12/drivers/media/video/Kconfig~	2005-06-27 01:37:39.000000000 -0400
> +++ linux-2.6.12/drivers/media/video/Kconfig	2005-06-27 01:37:56.000000000 -0400
> @@ -7,7 +7,7 @@ menu "Video For Linux"
>
> comment "Video Adapters"
>
> -config CONFIG_TUNER_MULTI_I2C
> +config TUNER_MULTI_I2C
> 	bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
> 	depends on VIDEO_DEV && EXPERIMENTAL
> 	---help---
>  
Dave-

If you do:

grep TUNER_MULTI_I2C < patch-2.6.12-git9

you will get:

+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C

... So in fact, after applying your patch above,  NOW it is a silly 
config option, which in effect, removed all functionality of 
CONFIG_TUNER_MULTI_I2C alltogether.  It so happens that this has been 
completely removed in the current -mm, and I've confirmed with Mauro 
Chehab (video4linux maintainer) that nothing will be broken after 
applying your patch, so there is nothing to worry about.  After the 
current tuner patches in -mm get merged, this whole thing will be a moot 
point.

--
Michael Krufky


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/