[PATCH] video.c: properly remove notify handlers

From: Karol Kozimor
Date: Wed Jun 29 2005 - 12:16:23 EST


Hi,
The video driver doesn't properly remove all the notify handlers on module
unload. This has a side effect of subdevices failing to register on module
reload, but sudden death looms if the handlers trigger after the module is
unloaded (not that I've seen such a machine, but still). Please apply.
Best regards,

--
Karol 'sziwan' Kozimor
sziwan@xxxxxxxxxxx

Signed-off-by: Karol Kozimor <sziwan@xxxxxxxxxxx>

--- a/drivers/acpi/video.c 2005-04-26 00:43:38.000000000 +0200
+++ b/drivers/acpi/video.c 2005-06-29 18:02:04.000000000 +0200
@@ -1666,6 +1666,7 @@
acpi_video_bus_put_one_device(
struct acpi_video_device *device)
{
+ acpi_status status;
struct acpi_video_bus *video;

ACPI_FUNCTION_TRACE("acpi_video_bus_put_one_device");
@@ -1680,6 +1681,12 @@
up(&video->sem);
acpi_video_device_remove_fs(device->dev);

+ status = acpi_remove_notify_handler(device->handle,
+ ACPI_DEVICE_NOTIFY, acpi_video_device_notify);
+ if (ACPI_FAILURE(status))
+ ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+ "Error removing notify handler\n"));
+
return_VALUE(0);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/