Re: [patch] latest inotify.

[Paulo Marques]

Robert Love wrote:
> Below is the latest inotify patch, against 2.6.12.
>
> [...]
> +/*
> + * fsnotify_oldname_init - save off the old filename before we change it
> + *
> + * XXX: This could be kstrdup if only we could add that to lib/string.c
> + */

I knew you were waiting for this, so I just wanted to let you know that 
the kstrdup function is already available in Linus tree 2.6.13-rc1. It 
is declared linux/string.h and implemented in mm/slab.c.

It is not implemented in lib/string.c because some architectures use lib 
functions in their bootloading code where the allocation functions are 
not available, and the linking stage then fails because of the kmalloc 
reference :P

--
Paulo Marques - www.grupopie.com

It is a mistake to think you can solve any major problems
just with potatoes.
Douglas Adams
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/