[TRIVIAL 2.6.12 / 2.6.13 PATCH] v4l cx88 hue offset fix
From: Michael Krufky
Date: Thu Jun 30 2005 - 11:20:34 EST
Mauro Carvalho Chehab wrote:
Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxx>
This small patch fixes top complaint about CX88 cards, which had a
different behavior than other V4L cards for hue setting.
It can also be applied also at 2.6.13 mainstream.
I must add: Not only does this apply to 2.6.13, but it also applies to
2.6.12 ... Can we have this put into the patch queue for 2.6.12.3 ?
This IS a bug fix, and makes a HUGE improvement for cx88 boards.
I'd really like to see this in the mainstream kernel before the livecd
distros make their next releases.
I would send this to Greg Kroah-Hartman / Chris Wright myself, but I
don't know if that is proper protocol for doing this. Andrew, please
send this to the correct person.
Thank you.
Attached is a diff against 2.6.12.2
--
Michael Krufky
Changed hue offset to 128 to correct behavior in cx88 cards. Previously,
setting 0% or 100% hue was required to avoid blue/green people on screen.
Now, 50% Hue means no offset, just like bt878 stuff.
Signed-off-by: Michael Krufky <mkrufky@xxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxx>
cx88-video.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -upr linux-2.6.12.2/drivers/media/video/cx88/cx88-video.c linux/drivers/media/video/cx88/cx88-video.c
--- linux-2.6.12.2/drivers/media/video/cx88/cx88-video.c 2005-06-17 15:48:29.000000000 -0400
+++ linux/drivers/media/video/cx88/cx88-video.c 2005-06-30 11:47:49.000000000 -0400
@@ -261,7 +261,7 @@ static struct cx88_ctrl cx8800_ctls[] =
.default_value = 0,
.type = V4L2_CTRL_TYPE_INTEGER,
},
- .off = 0,
+ .off = 128,
.reg = MO_HUE,
.mask = 0x00ff,
.shift = 0,