Re: [PATCH] multipath routing algorithm, better patch

[Thomas Graf]

* Patrick McHardy <42C4919A.5000009@xxxxxxxxx> 2005-07-01 02:43
> Multiple algorithms can be compiled in at once, so this patch is wrong.
> mp_alg is supplied by userspace:
> 
>         if (rta->rta_mp_alg) {
>                 mp_alg = *rta->rta_mp_alg;
> 
>                 if (mp_alg < IP_MP_ALG_NONE ||
>                     mp_alg > IP_MP_ALG_MAX)
>                         goto err_inval;
>         }
> 
> If it isn't set correctly its an iproute problem. Did you actually
> experience any problems?

Well, my patch for iproute2 to enable multipath algorithm selection
is currently being merged to Stephen together with the ematch bits.
We had to work out a dependency on GNU flex first (the berkley
version uses the same executable names) so the inclusion was
delayed a bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/