[PATCH] scripts/kernel-doc: don't use uninitialized SRCTREE

From: randy_dunlap
Date: Thu Jul 07 2005 - 17:44:52 EST



From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

Current kernel-doc (perl) script generates this warning:
Use of uninitialized value in concatenation (.) or string at scripts/kernel-doc line 1668.

so explicitly check for SRCTREE in the ENV before using it,
and then if it is set, append a '/' to the end of it, otherwise
the SRCTREE + filename can (will) be missing the intermediate '/'.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

diffstat:=
scripts/kernel-doc | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)

diff -Naurp linux-2613-rc2/scripts/kernel-doc~kernel-doc-srctree linux-2613-rc2/scripts/kernel-doc
--- linux-2613-rc2/scripts/kernel-doc~kernel-doc-srctree 2005-06-17 12:48:29.000000000 -0700
+++ linux-2613-rc2/scripts/kernel-doc 2005-07-07 14:33:01.000000000 -0700
@@ -1665,11 +1665,17 @@ sub xml_escape($) {
}

sub process_file($) {
- my ($file) = "$ENV{'SRCTREE'}@_";
+ my $file;
my $identifier;
my $func;
my $initial_section_counter = $section_counter;

+ if (defined($ENV{'SRCTREE'})) {
+ $file = "$ENV{'SRCTREE'}" . "/" . "@_";
+ }
+ else {
+ $file = "@_";
+ }
if (defined($source_map{$file})) {
$file = $source_map{$file};
}

---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/