Re: [PATCH] Provide better printk() support for SMP machines [try #2]

[Lars Marowsky-Bree]

On 2005-07-08T13:36:12, David Howells <dhowells@xxxxxxxxxx> wrote:

> The attached patch prevents oopses interleaving with characters from other
> printks on other CPUs by only breaking the lock if the oops is happening on
> the machine holding the lock.
> 
> It might be better if the oops generator got the lock and then called an inner
> vprintk routine that assumed the caller holds the lock, thus making oops
> reports "atomic".
> 
> Signed-Off-By: David Howells <dhowells@xxxxxxxxxx>

After some discussion on IRC (me asking dumb questions) and reviewing
the code I'm in infinite favour of this patch. It clearly is a step in a
mucho desireable direction.


Sincerely,
    Lars Marowsky-Brée <lmb@xxxxxxx>

-- 
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business	 -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/