Re: [patch] reduce stack footprint of functions in drivers/net/sk98lin/skgepnmi.c

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> this patch reduces the stack footprint of Vpd() from 1018 bytes to 28 
> bytes, SkPnmiGetStruct() from 744 bytes to 92 bytes, GetVpdKeyArr() 
> from 552 bytes to 48 bytes, and General() from 364 bytes to 112 bytes.

Benoît Dejean noticed that these changes are incorrect, because the code 
deals with KeyArr as an array of strings (and a 2D array), while my 
changes turn it into a char **. This breaks code like:

        Ret = GetVpdKeyArr(pAC, IoC, &KeyArr[0][0], sizeof(KeyArr), &KeyNo);
...
                                if (SK_STRCMP(KeyStr, KeyArr[Index]) == 0) {
...

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/