Re: [PATCH 0/82] changing CONFIG_LOCALVERSION rebuilds too much,for no good reason.

[Jeff Garzik]

Olaf Hering wrote:
> The following series of patches removes almost all inclusions
> of linux/version.h. The 3 #defines are unused in most of the touched files.
>
> A few drivers use the simple KERNEL_VERSION(a,b,c) macro, which is unfortunatly
> in linux/version.h. This define moved to linux/utsname.h
>
> There are also lots of #ifdef for long obsolete kernels, this will go as well.

I agree with most of the changes (and I say "most" simply because I 
haven't reviewed all of them), but it would be better to coalesce these 
100+ patches into much smaller patch clumps.

"split your patches up" mantra can get taken too far.  We want -logical 
changes- separated out, and your patches are largely a single logical 
change (remove old code).

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/