Re: [PATCH] Use device_for_each_child() to unregister devices in scsi_remove_target().

From: Greg KH
Date: Mon Jul 11 2005 - 19:23:46 EST


On Tue, Jul 05, 2005 at 05:38:50PM -0700, Patrick Mansfield wrote:
> Hi Greg / Patrick -
>
> I'm getting an oops with current (pulled today) 2.6 git, the
> device_for_each_child() does not seem to be deletion safe.
>
> We hold the klist in place via the n_ref, but the kobj (in the struct
> device for the struct scsi_target) containing it is freed when the
> kref->refcount goes to zero.

But we grab a reference to that object right before we call
device_for_each_child(), right? Or am I missing something here?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/