Re: [patch 7/12] s390: fba dasd i/o errors.

[Martin Schwidefsky]

> > @@ -354,6 +354,8 @@ dasd_fba_build_cp(struct dasd_device * d
> >          }
> >          cqr->device = device;
> >          cqr->expires = 5 * 60 * HZ;         /* 5 minutes */
> > +        cqr->retries = 32;
>
> 2..4 maybe, but 32? This isn't tiny by any account.

Are you arguing the use of the adjective "tiny" or the technical
aspects of using 32 as the number of retries for dasd fba?
In the dasd driver we use a retry count of 255 as "standard", so
32 is indeed much smaller than that. If you can call it tiny,
well who cares??

blue skies,
   Martin

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/