Re: [PATCH] Apple USB Touchpad driver (new)

[Vojtech Pavlik]

On Tue, Jul 12, 2005 at 09:47:16AM -0500, Dmitry Torokhov wrote:
> On 7/12/05, Stelian Pop <stelian@xxxxxxxxxx> wrote:
> > Le mardi 12 juillet 2005 ? 09:13 -0500, Dmitry Torokhov a écrit :
> > > Hi,
> > >
> > > On 7/12/05, Stelian Pop <stelian@xxxxxxxxxx> wrote:
> > > >
> > > > +       dev->input.id.bustype = BUS_USB;
> > > > +       dev->input.id.vendor = id->idVendor;
> > > > +       dev->input.id.product = id->idProduct;
> > > > +       dev->input.id.version = ATP_DRIVER_VERSION;
> > > > +
> > >
> > > Why don't we do what most of the other input devices and get version
> > > from the device too?
> > 
> > I guess we could, there is not much use for a local driver version
> > anyway.
> > 
> > > Actually we have this in input tree:
> > >
> > > static inline void
> > > usb_to_input_id(const struct usb_device *dev, struct input_id *id)
> > 
> > This cleans up a lot of code indeed. Too bad this is not upstream yet...
> > 
> 
> It is in -mm (it is coming from git-input patch).
 
Stelian, can you please update the patch to use usb_to_input_id()? It'll
go through -mm first, anyway, so there shouldn't be any issue with
Linus's kernels not having that function yet.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/