Re: RT and XFS

From: William Weston
Date: Tue Jul 12 2005 - 18:45:47 EST


On Tue, 12 Jul 2005, Daniel Walker wrote:

> Is there something so odd about the XFS locking, that it can't use the
> rt_lock ?
>
>
> --- linux.orig/fs/xfs/linux-2.6/mrlock.h
> +++ linux/fs/xfs/linux-2.6/mrlock.h
> @@ -37,12 +37,12 @@
> enum { MR_NONE, MR_ACCESS, MR_UPDATE };
>
> typedef struct {
> - struct rw_semaphore mr_lock;
> - int mr_writer;
> + struct compat_rw_semaphore mr_lock;
> + int mr_writer;
> } mrlock_t;

BTW, what's the difference between rw_semaphore and compat_rw_semaphore?
Or between semaphore and compat_semaphore? I ran into a similar issue
(needing compat_semaphore) with the IVTV drivers. The following is a
portion of my patch to get IVTV running under RT (the other portions are
just compile-time semantics):

--- ivtv-0.2.0-rc3k.orig/driver/msp3400.c 2004-11-19 08:21:04.000000000 -0800
+++ ivtv-0.2.0-rc3k/driver/msp3400.c 2005-06-22 17:26:24.000000000
-0700
@@ -115,7 +115,7 @@
struct task_struct *thread;
wait_queue_head_t wq;

- struct semaphore *notify;
+ struct compat_semaphore *notify;
int active,restart,rmmod;

int watch_stereo;

--ww
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/