Re: Inotify patch missed arch/x86_64/ia32/sys_ia32.c

[Andi Kleen]

On Fri, 15 Jul 2005 12:27:40 +0100
"Stephen C. Tweedie" <sct@xxxxxxxxxx> wrote:

> Hi,
> 
> The inotify patch just added a line
> 
> +				fsnotify_open(f->f_dentry);
> 
> to sys_open, but it missed the x86_64 compatibility sys32_open()
> equivalent in arch/x86_64/ia32/sys_ia32.c.

... and probably missing in the other compat layers too.
 
> Andi, perhaps it's time to factor out the guts of sys_open from the flag
> munging to keep as much of that code as common as possible, and avoid
> this sort of maintenance problem in the future?

No problem from my side if someone does a patch, but on the other hand if 
sys_open needs changes then likely all filp_open callers need too, and one would
better hope the patcher knows how to operate "grep -r" then. So it might
not buy much.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/