Re: [Ext2-devel] [RFC] [PATCH 2/4]delayed allocation for ext3

[Andreas Dilger]

On Jul 17, 2005  10:40 -0700, Mingming Cao wrote:
> @@ -373,6 +373,7 @@ struct ext3_inode {
>  #define EXT3_MOUNT_BARRIER		0x20000 /* Use block barriers */
>  #define EXT3_MOUNT_NOBH			0x40000 /* No bufferheads */
>  #define EXT3_MOUNT_QUOTA		0x80000 /* Some quota option set */
> + #define EXT3_MOUNT_DELAYED_ALLOC	0xC0000 /* Delayed Allocation */

This doesn't make sense.  DELAYED_ALLOC == QUOTA | NOBH?

> +     {Opt_delayed_alloc, "delalloc"},

Is this a replacement for Alex's delalloc code?  We also use delalloc for
that code and if they are not interchangeable it will cause confusion
about which one is in use.

> +     if (test_opt(sb, DELAYED_ALLOC)) {
> +             if (!(test_opt(sb, DATA_FLAGS) == EXT3_MOUNT_WRITEBACK_DATA)) {
> +                     printk(KERN_WARNING "EXT3-fs: Ignoring delall option - "
> +                             "its supported only with writeback mode\n");

Should be "ignoring delalloc option".
 
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/