Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

From: Moore, Eric Moore
Date: Wed Jul 20 2005 - 00:10:55 EST


On Tuesday, July 19, 2005 9:12 PM, Matt Domsch wrote:
What you illustrated above is not going to work.
If your doing #ifndef around a function, such as scsi_device_online, it's
not going to compile
when scsi_device_online is already implemented in the kernel tree.
The routine scsi_device_online is a function, not a define. For a define
this would work.

Sure it does, function names are defined symbols.


No its not compiling for me.
I'm currently building drivers for the DELL DKMS kit.
Trying to add support for SLES9 SP2 support ( -191 kernel).
My driver compiles for SLES9 Base(-97) and SP2(-139) but fails for SP2.
Between SP1 and SP2, they added msleep.

Here is the make.log output that you will find in /var/lib/dkms/mptlinux/3.02.52/build
when it fails to compile.

Also attached is linux_compat.h with the changes you have suggested.




Attachment: linux_compat.h
Description: Binary data

Attachment: make.log
Description: Binary data