Re: [PATCH] pci_find_device --> pci_get_device

[Jiri Slaby]

Rolf Eike Beer napsal(a):

> Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added 
> parts do not match in behaviour.
>  
I can't still see the difference.

if (pdev && (pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))
   *is_rio_p = 1;
else
   *is_rio_p = 0;
AND
*is_rio_p = !!(pdev && (pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS));

aren't the same or these:

   while (pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev))
       if (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
           pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS)
           break;
AND
 do {
       pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
       if (pdev &&
           (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
            pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))
           break;
   } while (pdev != NULL);

> If you add braces after if's please add the '{' in the same line as the if 
> itself. This will make the diff bigger, but then this matches 
> Documentation/Coding-style.
>  
Ok, this has been improved.

* Added for_each_pci_dev wherever it is appropriate.

New patch:
http://www.fi.muni.cz/~xslaby/lnx/lnx-pci_find-2.6.13-r3g4_2.patch
http://www.fi.muni.cz/~xslaby/lnx/lnx-pci_find-2.6.13-r3g4_2.patch.bz2

--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@xxxxxxxxx      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/