Re: [PATCH] add -Wun-def to global CFLAGS

From: Sam Ravnborg
Date: Thu Jul 21 2005 - 15:11:55 EST


On Thu, Jul 21, 2005 at 09:02:09PM +0200, Olaf Hering wrote:
>
> A recent change to the aic scsi driver removed two defines to detect
> endianness. cpp handles undefined strings as 0. As a result, the test turned
> into #if 0 == 0 and the wrong code was selected.
> Adding -Wundef to global CFLAGS will catch such errors.

To my suprise it did not spew out a lot of warnings in my build.
In the kernel we quite consitently use Â#ifdef - good!
Applied.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/