Re: [Alsa-devel] [PATCH] 2.6.13-rc3-git5: fix Bug #4416 (1/2)

From: Takashi Iwai
Date: Wed Jul 27 2005 - 03:54:26 EST


At Tue, 26 Jul 2005 12:51:47 +0200,
Rafael J. Wysocki wrote:
>
> The following patch adds free_irq() and request_irq() to the suspend and
> resume, respectively, routines in the snd_intel8x0 driver.

The patch looks OK to me although I have some concerns.

- The error in resume can't be handled properly.

What should we do for the error of request_irq()?

- Adding this to all drivers seem too much.

We just need to stop the irq processing until resume, so something
like suspend_irq(irq, dev_id) and resume_irq(irq, dev_id) would be
more uesful?


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/