Re: [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range

[Greg KH]

On Tue, Jul 26, 2005 at 01:32:00AM +0300, Michael S. Tsirkin wrote:
> Greg, Martin, does the following make sense?
> If it does, should other architectures be updated as well?
> 
> ---
> 
> Convert i386/pci to use io_remap_pfn_range instead of remap_pfn_range.
> 
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxxxxxx>
> 
> Index: linux-2.6.12.2/arch/i386/pci/i386.c
> ===================================================================
> --- linux-2.6.12.2.orig/arch/i386/pci/i386.c
> +++ linux-2.6.12.2/arch/i386/pci/i386.c
> @@ -295,9 +295,9 @@ int pci_mmap_page_range(struct pci_dev *
>  	/* Write-combine setting is ignored, it is changed via the mtrr
>  	 * interfaces on this platform.
>  	 */
> -	if (remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff,
> -			     vma->vm_end - vma->vm_start,
> -			     vma->vm_page_prot))
> +	if (io_remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff,
> +			       vma->vm_end - vma->vm_start,
> +			       vma->vm_page_prot))

Hm, you do realize that io_remap_pfn_range() is the same thing as
remap_pfn_range() on i386, right?

So, why would this patch change anything?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/