Re: 2.6.13-rc3-mm2

[Andrew Morton]

"Martin J. Bligh" <mbligh@xxxxxxxxxx> wrote:
>
> Seems to have some odd problem on PPC64 - crashes on boot.
>  Seems to affect power 4 boxes, both LPAR and bare metal.
> 
>  raid5: using function: 32regs (4524.000 MB/sec)
>  md: md driver 0.90.2 MAX_MD_DEVS=256, MD_SB_DISKS=27
>  md: bitmap version 3.38
>  oprofile: using ppc64/power4 performance monitoring.
>  NET: Registered protocol family 2
>  IP route cache hash table entries: 2097152 (order: 12, 16777216 bytes)
>  Badness in nr_blockdev_pages at fs/block_dev.c:399

This should fix:

--- devel/net/netlink/af_netlink.c~netlink-locking-fix	2005-07-27 14:10:07.000000000 -0700
+++ devel-akpm/net/netlink/af_netlink.c	2005-07-27 14:10:16.000000000 -0700
@@ -349,12 +349,12 @@ static int netlink_create(struct socket 
 
 	netlink_table_grab();
 	if (!nl_table[protocol].hash.entries) {
-		netlink_table_ungrab();
 #ifdef CONFIG_KMOD
 		/* We do 'best effort'.  If we find a matching module,
 		 * it is loaded.  If not, we don't return an error to
 		 * allow pure userspace<->userspace communication. -HW
 		 */
+		netlink_table_ungrab();
 		request_module("net-pf-%d-proto-%d", PF_NETLINK, protocol);
 		netlink_table_grab();
 #endif
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/