Re: include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree

From: Coywolf Qi Hunt
Date: Thu Jul 28 2005 - 22:08:59 EST


On 7/29/05, akpm@xxxxxxxx <akpm@xxxxxxxx> wrote:
>
> The patch titled
>
> include/linux/blkdev.h: "extern inline" -> "static inline"
>
> has been added to the -mm tree. Its filename is
>
> include-linux-blkdevh-extern-inline-static-inline.patch
>

...

>
>
> From: Adrian Bunk <bunk@xxxxxxxxx>
>
> "extern inline" doesn't make much sense.

"extern inline" does make sense, and it does make sense here. please
backout this patch. Hint: the address of block_size() is referenced.

>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> ---
>
> include/linux/blkdev.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline include/linux/blkdev.h
> --- devel/include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline 2005-07-28 19:28:05.000000000 -0700
> +++ devel-akpm/include/linux/blkdev.h 2005-07-28 19:28:05.000000000 -0700
> @@ -727,7 +727,7 @@ static inline unsigned int blksize_bits(
> return bits;
> }
>
> -extern inline unsigned int block_size(struct block_device *bdev)
> +static inline unsigned int block_size(struct block_device *bdev)
> {
> return bdev->bd_block_size;
> }



--
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/