Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

From: Jeff Garzik
Date: Fri Jul 29 2005 - 17:29:04 EST


Gaston, Jason D wrote:
This define is not actually used anywhere that I know of. I just wanted
to be consistent and correct, following what was previously done. I
have been wondering if I should be adding devices to the pci_ids.h file
that are not being currently used. It seems like most drivers are not
using these defines and are just using the DID's directly. In the
future, should I only be add devices that are actually using the defines
somewhere?

There's no clear policy, but that is my general recommendation: Just add IDs to pci.ids at sourceforge.net as soon as their public, and then, add constants to include/linux/pci_ids.h as they are required in the code.

I would -prefer- that this be kernel policy, but I can only speak for IDs used [or not] in my drivers. It just seems silly to add constants that are never used, though.

[speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info in pci.ids.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/