Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

From: Jeff Garzik
Date: Fri Jul 29 2005 - 17:35:28 EST


Andrew Morton wrote:
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

[speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info in pci.ids.


It looks like Greg is planning on nuking pci.ids.

From the kernel, yes, that's been long planned. But not from existence.

The kernel source code is an inappropriate place to store random hex numbers that the kernel itself does not use.

Or IOW, we shouldn't be knowingly storing dead code in linux/pci_ids.h :)

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/