Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

From: Jeff Garzik
Date: Fri Jul 29 2005 - 22:55:39 EST


Grant Coady wrote:
On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

[speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used.


Only these seem not referenced by source:
PCI_CLASS_SYSTEM_PCI_HOTPLUG
PCI_DEVICE_ID_CYRIX_PCI_MASTER
PCI_DEVICE_ID_HP_PCI_LBA
PCI_DEVICE_ID_NP_PCI_FDDI
PCI_DEVICE_ID_UPCI_RM3_4PORT
PCI_DEVICE_ID_UPCI_RM3_8PORT

Source macros refer to:
BROOKTREE sound/pci/bt87x.c
YAMAHA sound/oss/ymfpci.c

6 from 2329 entries hardly worth it?

However you did your search, you did it wrong. The very first two entries I tried had zero uses:

[jgarzik@pretzel linux-2.6]$ grepsrc ICH7_22
./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_22 0x27e0
[jgarzik@pretzel linux-2.6]$ grepsrc ICH7_23
./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_23 0x27e2
[jgarzik@pretzel linux-2.6]$

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/