Re: ahci, SActive flag, and the HD activity LED

From: Jens Axboe
Date: Wed Aug 03 2005 - 01:18:48 EST


On Wed, Aug 03 2005, Martin Wilck wrote:
> Jens Axboe wrote:
>
> >>If I am reading the specs correctly, that'd mean the ahci driver is
> >>wrong in setting the SActive bit.
> >
> >I completely agree, that was my reading of the spec as well and hence my
> >original posts about this in the NCQ thread.
>
> Have you (or has anybody else) also seen the wrong behavior of the
> activity LED?

No, but I have observed that SActive never gets cleared by the device
for non-NCQ commands (which is probably which gets you the stuck LED on
some systems?), which to me is another indication that we should not be
setting the tag bits for those commands.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/