Re: [10/13] [PATCH] bio_clone fix

[Jens Axboe]

On Wed, Aug 03 2005, Chris Wright wrote:
> -stable review patch.  If anyone has any objections, please let us know.

Full ack.

> 
> ------------------
> 
> [PATCH] bio_clone fix
> 
> Fix bug introduced in 2.6.11-rc2: when we clone a BIO we need to copy over the
> current index into it as well.
> 
> It corrupts data with some MD setups.
> 
> See http://bugzilla.kernel.org/show_bug.cgi?id=4946
> 
> Huuuuuuuuge thanks to Matthew Stapleton <matthew4196@xxxxxxxxx> for doggedly
> chasing this one down.
> 
> Acked-by: Jens Axboe <axboe@xxxxxxx>
> Cc: <linux-raid@xxxxxxxxxxxxxxx>
> Cc: <dm-devel@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
> Signed-off-by: Chris Wright <chrisw@xxxxxxxx>
> ---
> 
>  fs/bio.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> diff --git a/fs/bio.c b/fs/bio.c
> --- a/fs/bio.c
> +++ b/fs/bio.c
> @@ -261,6 +261,7 @@ inline void __bio_clone(struct bio *bio,
>  	 */
>  	bio->bi_vcnt = bio_src->bi_vcnt;
>  	bio->bi_size = bio_src->bi_size;
> +	bio->bi_idx = bio_src->bi_idx;
>  	bio_phys_segments(q, bio);
>  	bio_hw_segments(q, bio);
>  }
> -
> 

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/