Re: [patch 2.6.13-rc4] fix get_user_pages bug

From: Nick Piggin
Date: Wed Aug 03 2005 - 18:21:13 EST


Linus Torvalds wrote:

On Wed, 3 Aug 2005, Nick Piggin wrote:

Oh, it gets rid of the -1 for VM_FAULT_OOM. Doesn't seem like there
is a good reason for it, but might that break out of tree drivers?


Ok, I applied this because it was reasonably pretty and I liked the approach. It seems buggy, though, since it was using "switch ()" to test the bits (wrongly, afaik),

Oops, thanks.

and I'm going to apply the appended on top of it. Holler quickly if you disagreee..


No that looks fine. Should really be credited to Hugh... well
I guess everyone had some input into it though (Andrew, Hugh,
you, me). It probably doesn't matter too much.

Thanks everyone.

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/