Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

[Edward Falk]

>  I agree that above code should clear both.  Just wanna verify.  Have
> you tested it and/or do you have any information confirming this?  If
> we don't have any further info, I think we should read PORT_SLOT_STAT
> before clearing PORT_IRQ_STAT to be on the safe side.

I've implemented the clear_irq() function to clear all interrupts as you 
said, but haven't had time to test this thoroughly.  Ultimately, we 
don't know if it works until we experience real errors and see how the 
system responds.

I don't think it matters in which order you do things, as long as you 
allow for the fact that reading PORT_SLOT_STAT will clear the command 
completion interrupt flag.

	-ed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/