Re: obsolete modparam change busted.

[Rusty Russell]

On Mon, 2005-08-08 at 14:49 -0400, Dave Jones wrote:
> However this change was broken, and if the modprobe.conf
> has trailing whitespace, modules fail to load with the
> following helpful message..

Hi Dave,

	This fix should be preferable, I think.

Name: Ignore trailing whitespace on kernel parameters correctly
Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Dave Jones says:

... if the modprobe.conf has trailing whitespace, modules fail to load
with the following helpful message..

	snd_intel8x0: Unknown parameter `'

--- linux-2.6.12/kernel/params.c	2005-07-15 04:39:53.000000000 +1000
+++ /tmp/foo.c	2005-08-09 13:56:04.000000000 +1000
@@ -1,0 +1,0 @@
@@ -135,11 +80,8 @@
 
 	DEBUGP("Parsing ARGS: %s\n", args);
 
-	while (*args) {
-		int ret;
-
-		args = next_arg(args, &param, &val);
-		ret = parse_one(param, val, params, num, unknown);
+	while (*(args = next_arg(args, &param, &val))) {
+		int ret = parse_one(param, val, params, num, unknown);
 		switch (ret) {
 		case -ENOENT:
 			printk(KERN_ERR "%s: Unknown parameter `%s'\n",

-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/