Re: files_lock deadlock?

[Martin Wilck]

Arjan van de Ven wrote:

> doing anything with files implies having a defined usercontext really,
> and generally sleeping as well. So think this is quite safe.

Looking closer at this, I'd say that files_lock should be replaced by 
locking of the respective lists (struct sb->s_files and struct 
tty_struct->tty_files, unless I'm mistaken),  and that this locking 
should be done with semaphores. Right?

Going through the list of all sb->s_files can be a costly operation; it 
may be worthwile to have a per-sb locking mechanism for that.

Martin

--
Martin Wilck                Phone: +49 5251 8 15113
Fujitsu Siemens Computers   Fax:   +49 5251 8 20409
Heinz-Nixdorf-Ring 1        mailto:Martin.Wilck@xxxxxxxxxxxxxxxxxxx
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/