Re: w1: more debug level decrease.

From: Andi Kleen
Date: Fri Aug 12 2005 - 15:16:55 EST


Greg KH <greg@xxxxxxxxx> writes:

> Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

But why is this thing running every 10 seconds at all in the first place?
Looks to me like you're just hiding the symptoms, not fixing the bug
that makes this code run on unsuspecting systems.

e.g. one way would be to only probe once and then never again.

-Andi

>
> From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
>
> Do not spam syslog each 10 seconds when there is nothing on the wire.
>
> Signed-off-by: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> ---
> drivers/w1/w1.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- gregkh-2.6.orig/drivers/w1/w1.c 2005-08-02 13:41:30.000000000 -0700
> +++ gregkh-2.6/drivers/w1/w1.c 2005-08-12 11:42:04.000000000 -0700
> @@ -593,7 +593,7 @@
> * Return 0 - device(s) present, 1 - no devices present.
> */
> if (w1_reset_bus(dev)) {
> - dev_info(&dev->dev, "No devices present on the wire.\n");
> + dev_dbg(&dev->dev, "No devices present on the wire.\n");
> break;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/