Re: [patch 2.6.13-rc6] Fix kmem read on 32-bit archs

From: Andi Kleen
Date: Sun Aug 14 2005 - 11:22:28 EST


On Sun, Aug 14, 2005 at 12:12:52PM -0400, Chuck Ebbert wrote:
> The first thing drivers/char/mem.c:read_kmem does is convert the
> loff_t it gets as the offset for reading into an unsigned int. This
> patch makes the kmem driver's llseek operator do that up-front, so
> that fs/read_write.c:rw_verify_area doesn't return -EINVAL when
> we try to read from higher addresses.
>
> It's ugly but so is the existing code. And it won't fix 64-bit
> archs AFAICT. Tested on 2.6.11, patch offsets fixed up for 2.6.13-rc6.

I already have a full patch for this issue queued for 2.6.14.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/