Re: [PATCH 4/4] cciss 2.4: fixes a warning from cciss_scsi.c during compile

From: Alexey Dobriyan
Date: Mon Aug 15 2005 - 16:47:36 EST


On Mon, Aug 15, 2005 at 04:24:25PM -0500, mikem wrote:
> This patch fixes a warning during compile.

> --- lx2431-p003/drivers/block/cciss_scsi.c
> +++ lx2431/drivers/block/cciss_scsi.c
> @@ -220,8 +220,7 @@ scsi_cmd_stack_free(int ctlr)
> printk( "cciss: %d scsi commands are still outstanding.\n",
> CMD_STACK_SIZE - stk->top);
> // BUG();
> - printk("WE HAVE A BUG HERE!!! stk=0x%08x\n",
> - (unsigned int) stk);
> + printk("WE HAVE A BUG HERE!!! stk=0x%p\n", stk);

If we have a BUG() here why it's commented out? If we don't, remove
printk() together with BUG().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/